labath added inline comments.
================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:122
+PropertyDefinition g_experimental_properties[] = {
+ {"use-debug-names", OptionValue::eTypeBoolean, true, 0, nullptr, nullptr,
+ "Use .debug_names index section."},
----------------
clayborg wrote:
> Would it be better to use an inverse setting like "always-manually-index"?
> That way if there is something wrong with any of the indexes that are
> generated, then we can fall back to manually indexing? Otherwise we will need
> to remove this later.
In the interests of non-proliferation of settings I have deliberately chosen a
path that does not make the setting permanent. However, this does sound like a
thing that could conceivably be useful as a setting in general, so I can do
that too if you think it's better.
Would you then also make the setting non-experimental?
https://reviews.llvm.org/D47629
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
