sas added inline comments.
================
Comment at: scripts/CMakeLists.txt:38
OUTPUT ${LLDB_WRAP_PYTHON}
- OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py
DEPENDS ${SWIG_SOURCES}
----------------
xiaobai wrote:
> sas wrote:
> > ...and this path were not the same before your change. Was that a bug that
> > you're fixing?
> Yes. Those paths were actually the same if you were not building the
> framework, which is why this bug never surfaced. Specifically,
> `${CMAKE_CURRENT_BINARY_DIR}` in scripts/CMakeLists.txt resolves to the same
> path as `${CMAKE_CURRENT_BINARY_DIR}/scripts` in the top level CMakeLists.txt.
>
> The pitfall is the assumption that this path is always the same as
> `${LLDB_PYTHON_TARGET_DIR}`, which it is not if you are trying to build the
> framework.
Makes sense. This should be good to go then.
https://reviews.llvm.org/D47742
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
