labath added a comment.

Changing the code to filter based on the dwarf information instead of the going 
through CompilerDeclContexts sounds like a good idea. I've been wondering why 
we are doing it this way -- the explanation I gave to myself was that this 
would allow the individual language plugins to decide what represents a "class" 
instead of just searching for DW_TAG_structure_type and similar. However, it's 
very likely that this is extra flexibility we don't need (and indeed, the 
manual index just checks the dwarf tags while building the index).

Unfortunately, something's come up, so I wasn't able to look into this closer 
today. Hopefully, I'll be able to get back to this patch later this week.


https://reviews.llvm.org/D47147



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to