friss accepted this revision. friss added inline comments. This revision is now accepted and ready to land.
================ Comment at: source/Host/macosx/HostInfoMacOSX.mm:288 + // Fall back to the Clang resource directory inside the framework. + raw_path.resize(rev_it - r_end); raw_path.append("/Resources/Clang"); ---------------- As both branches above also resize, I think it would be clearer if this resize was in a final else above rather than on its own. Otherwise this LGTM https://reviews.llvm.org/D46736 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits