[Lldb-commits] [PATCH] D46606: General cleanup to minimize the .debug_types patch

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

This looks fine to me. I am not clicking accept yet, so other debug info folks 
can take a look at this too.



================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:28
   // Out of memory?
-  if (cu_sp.get() == NULL)
+  if (!cu_sp)
     return nullptr;
----------------
This is dead code. `new` will abort the program if it cannot allocate memory 
for the object. 


https://reviews.llvm.org/D46606



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits