aprantl added inline comments.
================
Comment at: source/Utility/FileSpec.cpp:107
+ for (auto i = path.find('/'); i != llvm::StringRef::npos;
+ i = path.find('/', i + 1)) {
+ const auto nextChar = safeCharAtIndex(path, i+1);
----------------
clayborg wrote:
> no as the only caller to this function switches the slashes to '/' already..
If we change that to also replace double-`/` with singles, we could replace
this function with a call to llvm::sys::path::remove_dots()
http://llvm.org/doxygen/namespacellvm_1_1sys_1_1path.html#a35c103b5fb70a66a1cb5da3b56f588a1
================
Comment at: source/Utility/FileSpec.cpp:115
+ case '/':
+ // "//" in the middle of a path needs to be normalized
+ if (i > 0)
----------------
Does this also turn "//WORKGROUP/Foo" into "/WORKGROUP/Foo/"?
https://reviews.llvm.org/D45977
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
