jankratochvil added inline comments.
Herald added a reviewer: espindola.
================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:595
+ uint64_t debug_info_size = get_debug_info_data().GetByteSize();
+ data_segment.m_data.OffsetData(debug_info_size);
+ }
----------------
I do not like this `DWARFDataExtractor::m_start` modification, it sort of
corrupts the `DataExtractor` and various operations stop working then - such as
`DWARFDataExtractor::GetByteSize()`. DWZ patch makes from current `dw_offset_t`
a virtual (remapped) offset and introduces new physical file section offset
which is looked up for data extraction. The file offset is represented as
`DWARFFileOffset` in D40474, instead of `bool m_is_dwz;` there could be some
`enum { DEBUG_INFO, DEBUG_TYPES, DWZ_DEBUG_INFO } m_where;` instead.
https://reviews.llvm.org/D32167
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
