friss added inline comments.
================ Comment at: packages/Python/lldbsuite/test/tools/lldb-server/TestAppleSimulatorOSType.py:16-18 + sim_devices_str = subprocess.check_output(['xcrun', 'simctl', 'list', '-j', + 'devices']) + sim_devices = json.loads(sim_devices_str)['devices'] ---------------- labath wrote: > I think these will cause a problem as they will be executed even if the test > is skipped. Will this throw an exception if "xcrun" fails (e.g. because > you're on linux). It might be best to move this into some function.. Yep, I coincidentally realized this on my commute this morning. I'll fix it. ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:50 static const char *const THREAD_COMMAND_SEGFAULT = "segfault"; +static const char *const THREAD_COMMAND_PRINT_PID = "print-pid"; ---------------- labath wrote: > I don't think this needs to be a thread command, as the pid is not > thread-specific. We could just make this a regular command like print-message > et al. No problem. https://reviews.llvm.org/D45298 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
