davide added a comment.
I think this is almost ready to go in modulo minors. I'll let also @labath
comment on it. Thanks for your contribution!
Do you need somebody to commit this on your behalf?
================
Comment at:
packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/TestBreakpointThumbCodesection.py:2
+"""
+Test that breakpoints correctly work in an thumb function in an atritbary
+named codesection.
----------------
nit: arbitrary.
================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1950-1954
+ if (eSectionTypeOther == sect_type &&
+ llvm::ELF::SHT_PROGBITS == header.sh_type &&
+ (header.sh_flags & SHF_EXECINSTR)) {
+ sect_type = eSectionTypeCode;
+ }
----------------
can you add a comment explaining why this is needed?
https://reviews.llvm.org/D44998
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
