clayborg added a comment.
Looks fine. It would be nice to verify that there are no performance
regressions due to this before making this change. Can you do some timings to
make sure? Do anything that indexes a large C++ DWARF codebase, like clang, and
make sure we don't regress by a significant amount.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:765-766
size_t DWARFDebugInfoEntry::GetAttributes(
- const DWARFUnit *cu, DWARFFormValue::FixedFormSizes fixed_form_sizes,
+ const DWARFUnit *cu,
+ llvm::dwarf::FormParams form_params,
DWARFAttributes &attributes, uint32_t curr_depth) const {
----------------
formatting?
https://reviews.llvm.org/D44739
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
