jingham added a comment.

I still worry a bit because there's another unstated responsibility for Args 
which is that even though it is going to get used at a very high level in lldb 
it has to NOT depend on anything you don't want lldb-server to depend on.  That 
seems like a more slippery responsibility, and one that's worth stating 
explicitly by making the part of Args that gets used in lldb-server its own 
class.  But on the implementation wins principle, as long as this doesn't worry 
you, I'm content.

BTW, most the string -> int/address/whatever conversion functions don't belong 
in Args at all.  It makes these fairly useful functions hard to find, and we 
should have some string conversion utility to hold all these convenience 
functions.  There are a few (like picking an enum option string from a set of 
enums) that belong more properly in options.  But most of them have no real 
relation to Args.  But that's an orthogonal issue.


https://reviews.llvm.org/D43837



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to