zturner added a comment. In the future when you upload diffs can you include context? (i.e. `git diff -U999999`). It's nice to be able to see the surrounding code when I'm looking at a diff.
Is there ever a case where you would want to build a shared library without `-fPIC`? I'm wondering if we should just update the common `Makefile.rules` and if `DYLIB_NAME` is set (or something else indicating that this is a shared library), then we put the logic about `-fPIC` in that common file. Then people wouldn't have to remember to get this right in the future. Repository: rL LLVM https://reviews.llvm.org/D42994 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
