clayborg added a comment. In https://reviews.llvm.org/D39967#985181, @labath wrote:
> In https://reviews.llvm.org/D39967#985171, @clayborg wrote: > > > That would be an easy fix for the ObjectFile::Load(), we could see if there > > are any breakpoints in the range we are trying to write, get a list of > > them, disable them all, write memory and re-enable. But this doesn't stop a > > user from trying doing something like: > > > > (lldb) script lldb.process.WriteMemory(...) > > > > > > And they should expect this to just work no matter where they write memory. > > > Couldn't WriteMemory do the same thing as well? I would expect that 99% of > WriteMemory calls will not intersect any breakpoints so the overhead of > disabling and re-enabling should be negligible. Indeed the fix could do this to make this easier and I agree that would be a cleaner fix. We already have all the APIs we need for this. Tatyana, let us know what you think of changing this patch to get a list of overlapping breakpoints, disable, write memory, re-enable. All from within Process::WriteMemory https://reviews.llvm.org/D39967 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
