aprantl added a comment. Thanks, this is a great start!
================ Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:240 +CLANG_MODULE_CACHE_DIR := module-cache + ---------------- Is it safe that this is a relative path? ================ Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:242 + +MANDATORY_MODULE_BUILD_CFLAGS := -fmodules -fmodules-cache-path=$(CLANG_MODULE_CACHE_DIR) + ---------------- Should we also specify `-fcxxmodules` here? Or will that break some bots with older clangs? https://reviews.llvm.org/D42277 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
