clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed.
Very cool and close. It would be nice to function correctly without asserts, see inlined comment. ================ Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2105-2106 + // FIXME: This should detect covariant return types, but currently doesn't. + assert(&m1->getASTContext() == &m2->getASTContext() && + "Methods should have the same AST context"); + clang::ASTContext &context = m1->getASTContext(); ---------------- Use lldb_assert and possibly return false afterwards in case the asserts are compiled out Repository: rL LLVM https://reviews.llvm.org/D41997 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
