clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land.
Won't hold up the checkin for the cleaner while loop, but feel free to fix that and checkin if it works. ================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp:248-249 - while (cu->Extract(dwarf2Data->get_debug_info_data(), &offset)) { + for (;;) { + DWARFCompileUnitSP cu = DWARFCompileUnit::Extract(dwarf2Data, &offset); + if (cu.get() == NULL) ---------------- Might be cleaner to do: ``` DWARFCompileUnitSP cu; while ((cu = DWARFCompileUnit::Extract(dwarf2Data, &offset))) { ``` https://reviews.llvm.org/D40212 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits