On Tue, Oct 31, 2017 at 8:20 AM Pavel Labath <lab...@google.com> wrote:
> On 31 October 2017 at 15:12, Zachary Turner via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > The takeaway from this example is nothing we don't already know. We need > > better test coverage. > Actually, this was caught by a test (pretty much all of them), but > only when building with libc++, as the code was "safe" with libstdc++ > due to the copy-on-write implementation of std::string (the temporary > object shared storage with the longer-lived string it was copied > from). > What version of libstdc++? AFAIK copy-on-write std::string is no longer conformant in C++11. If this was really being masked due to a CoW string implementation, we need to make absolutely sure we are running tests on a bot with a conformant standard library.
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
