zturner added inline comments.
================ Comment at: CMakeLists.txt:15 +# Define the LLDB_CONFIGURATION_xxx matching the build type +if( uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG" ) + add_definitions( -DLLDB_CONFIGURATION_DEBUG ) ---------------- I'm pretty sure that if you run CMake without specifying anything for `CMAKE_BUILD_TYPE` then the default is debug, but it doesn't internally set `CMAKE_BUILD_TYPE=Debug`. Can you double check this handles the default case appropriately? https://reviews.llvm.org/D38552 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
