> On Sep 11, 2017, at 4:05 PM, Leonard Mosescu <mose...@google.com> wrote:
>
>
> Process already has "Error Process::WillResume()" for this very reason. Just
> have the Windows mini dump core file plug-in override it. The code in
> Process::Resume already checks this:
> Status Process::PrivateResume() {
> Status error(WillResume());
> // Tell the process it is about to resume before the thread list
> if (error.Success()) {
> ...
> }
> }
> return error;
> }
> Problem solved no???
>
> It would be great, but that also happens too late (by the time
> PrivateResume() is called the state has been already changed)
We could call Process::WillResume() before Process::PrivateResume() before it
changes the state... Probably still need to call it in PrivateResume() since a
complex thread plan might start and stop the process many times and the process
might crash and there would only be one main Process::Continue, or thread step
that kicks off the initial run.
Greg
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
