[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE doesn't contain any valid address

[Nitesh Jain via Phabricator via lldb-commits]

nitesh.jain updated this revision to Diff 110364.
nitesh.jain retitled this revision from "[LLD][MIPS] Fix 
Address::GetAddressClass() to return correct AddressClass based on the load 
address" to "[LLDB][MIPS] The symbol with NOTYPE doesn't contain any valid 
address".

https://reviews.llvm.org/D35784

Files:
  source/Symbol/Symbol.cpp


Index: source/Symbol/Symbol.cpp
===================================================================
--- source/Symbol/Symbol.cpp
+++ source/Symbol/Symbol.cpp
@@ -113,6 +113,8 @@
 }
 
 bool Symbol::ValueIsAddress() const {
+  if (m_type == eSymbolTypeInvalid)
+    return false;
   return m_addr_range.GetBaseAddress().GetSection().get() != nullptr;
 }
 



Index: source/Symbol/Symbol.cpp
===================================================================
--- source/Symbol/Symbol.cpp
+++ source/Symbol/Symbol.cpp
@@ -113,6 +113,8 @@
 }
 
 bool Symbol::ValueIsAddress() const {
+  if (m_type == eSymbolTypeInvalid)
+    return false;
   return m_addr_range.GetBaseAddress().GetSection().get() != nullptr;
 }
 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits