https://github.com/Teemperor created https://github.com/llvm/llvm-project/pull/208673
No one outside Apple can access the associated radars and understand what these tests are about. These tests have other problems, but this makes them at least possible to comprehend for everyone. >From 57551f172630b16a22e311816e8796ec3e2fe2b6 Mon Sep 17 00:00:00 2001 From: Raphael Isemann <[email protected]> Date: Fri, 10 Jul 2026 10:22:04 +0100 Subject: [PATCH] [lldb][test] Get rid of radar references in test names No one outside Apple can access the associated radars and understand what these tests are about. These tests have other problems, but this makes them at least possible to comprehend for everyone. --- .../import/{rdar-12586188 => import-error}/Makefile | 0 .../TestImportError.py} | 8 ++++---- .../fail12586188.py => import-error/fail_importerror.py} | 0 .../fail212586188.py => import-error/fail_valueerror.py} | 0 .../{rdar44436068 => int128}/Test128BitsInteger.py | 0 .../commands/expression/{rdar44436068 => int128}/main.c | 0 .../{rdar42038760 => urem-sign}/TestScalarURem.py | 0 .../expression/{rdar42038760 => urem-sign}/main.c | 0 .../{Test-rdar-9974002.py => TestSummaryStringOnFail.py} | 4 +--- .../objc/{rdar-10967107 => coalesced-cf-types}/Makefile | 0 .../TestCoalescedCFTypes.py} | 2 +- .../objc/{rdar-10967107 => coalesced-cf-types}/main.m | 0 .../{rdar-12408181 => dynamic-type-children}/Makefile | 0 .../TestDynamicTypeChildren.py} | 2 +- .../objc/{rdar-12408181 => dynamic-type-children}/main.m | 0 15 files changed, 7 insertions(+), 9 deletions(-) rename lldb/test/API/commands/command/script/import/{rdar-12586188 => import-error}/Makefile (100%) rename lldb/test/API/commands/command/script/import/{rdar-12586188/TestRdar12586188.py => import-error/TestImportError.py} (78%) rename lldb/test/API/commands/command/script/import/{rdar-12586188/fail12586188.py => import-error/fail_importerror.py} (100%) rename lldb/test/API/commands/command/script/import/{rdar-12586188/fail212586188.py => import-error/fail_valueerror.py} (100%) rename lldb/test/API/commands/expression/{rdar44436068 => int128}/Test128BitsInteger.py (100%) rename lldb/test/API/commands/expression/{rdar44436068 => int128}/main.c (100%) rename lldb/test/API/commands/expression/{rdar42038760 => urem-sign}/TestScalarURem.py (100%) rename lldb/test/API/commands/expression/{rdar42038760 => urem-sign}/main.c (100%) rename lldb/test/API/functionalities/data-formatter/summary-string-onfail/{Test-rdar-9974002.py => TestSummaryStringOnFail.py} (97%) rename lldb/test/API/lang/objc/{rdar-10967107 => coalesced-cf-types}/Makefile (100%) rename lldb/test/API/lang/objc/{rdar-10967107/TestRdar10967107.py => coalesced-cf-types/TestCoalescedCFTypes.py} (97%) rename lldb/test/API/lang/objc/{rdar-10967107 => coalesced-cf-types}/main.m (100%) rename lldb/test/API/lang/objc/{rdar-12408181 => dynamic-type-children}/Makefile (100%) rename lldb/test/API/lang/objc/{rdar-12408181/TestRdar12408181.py => dynamic-type-children/TestDynamicTypeChildren.py} (98%) rename lldb/test/API/lang/objc/{rdar-12408181 => dynamic-type-children}/main.m (100%) diff --git a/lldb/test/API/commands/command/script/import/rdar-12586188/Makefile b/lldb/test/API/commands/command/script/import/import-error/Makefile similarity index 100% rename from lldb/test/API/commands/command/script/import/rdar-12586188/Makefile rename to lldb/test/API/commands/command/script/import/import-error/Makefile diff --git a/lldb/test/API/commands/command/script/import/rdar-12586188/TestRdar12586188.py b/lldb/test/API/commands/command/script/import/import-error/TestImportError.py similarity index 78% rename from lldb/test/API/commands/command/script/import/rdar-12586188/TestRdar12586188.py rename to lldb/test/API/commands/command/script/import/import-error/TestImportError.py index 61c10dc172606..e60f734db3d0d 100644 --- a/lldb/test/API/commands/command/script/import/rdar-12586188/TestRdar12586188.py +++ b/lldb/test/API/commands/command/script/import/import-error/TestImportError.py @@ -7,10 +7,10 @@ from lldbsuite.test import lldbutil -class Rdar12586188TestCase(TestBase): +class ImportErrorTestCase(TestBase): @add_test_categories(["pyapi"]) @no_debug_info_test - def test_rdar12586188_command(self): + def test_import_error_command(self): """Check that we handle an ImportError in a special way when command script importing files.""" self.run_test() @@ -18,12 +18,12 @@ def run_test(self): """Check that we handle an ImportError in a special way when command script importing files.""" self.expect( - "command script import ./fail12586188.py --allow-reload", + "command script import ./fail_importerror.py --allow-reload", error=True, substrs=['raise ImportError("I do not want to be imported")'], ) self.expect( - "command script import ./fail212586188.py --allow-reload", + "command script import ./fail_valueerror.py --allow-reload", error=True, substrs=['raise ValueError("I do not want to be imported")'], ) diff --git a/lldb/test/API/commands/command/script/import/rdar-12586188/fail12586188.py b/lldb/test/API/commands/command/script/import/import-error/fail_importerror.py similarity index 100% rename from lldb/test/API/commands/command/script/import/rdar-12586188/fail12586188.py rename to lldb/test/API/commands/command/script/import/import-error/fail_importerror.py diff --git a/lldb/test/API/commands/command/script/import/rdar-12586188/fail212586188.py b/lldb/test/API/commands/command/script/import/import-error/fail_valueerror.py similarity index 100% rename from lldb/test/API/commands/command/script/import/rdar-12586188/fail212586188.py rename to lldb/test/API/commands/command/script/import/import-error/fail_valueerror.py diff --git a/lldb/test/API/commands/expression/rdar44436068/Test128BitsInteger.py b/lldb/test/API/commands/expression/int128/Test128BitsInteger.py similarity index 100% rename from lldb/test/API/commands/expression/rdar44436068/Test128BitsInteger.py rename to lldb/test/API/commands/expression/int128/Test128BitsInteger.py diff --git a/lldb/test/API/commands/expression/rdar44436068/main.c b/lldb/test/API/commands/expression/int128/main.c similarity index 100% rename from lldb/test/API/commands/expression/rdar44436068/main.c rename to lldb/test/API/commands/expression/int128/main.c diff --git a/lldb/test/API/commands/expression/rdar42038760/TestScalarURem.py b/lldb/test/API/commands/expression/urem-sign/TestScalarURem.py similarity index 100% rename from lldb/test/API/commands/expression/rdar42038760/TestScalarURem.py rename to lldb/test/API/commands/expression/urem-sign/TestScalarURem.py diff --git a/lldb/test/API/commands/expression/rdar42038760/main.c b/lldb/test/API/commands/expression/urem-sign/main.c similarity index 100% rename from lldb/test/API/commands/expression/rdar42038760/main.c rename to lldb/test/API/commands/expression/urem-sign/main.c diff --git a/lldb/test/API/functionalities/data-formatter/summary-string-onfail/Test-rdar-9974002.py b/lldb/test/API/functionalities/data-formatter/summary-string-onfail/TestSummaryStringOnFail.py similarity index 97% rename from lldb/test/API/functionalities/data-formatter/summary-string-onfail/Test-rdar-9974002.py rename to lldb/test/API/functionalities/data-formatter/summary-string-onfail/TestSummaryStringOnFail.py index d5db44a6c1455..5096283908622 100644 --- a/lldb/test/API/functionalities/data-formatter/summary-string-onfail/Test-rdar-9974002.py +++ b/lldb/test/API/functionalities/data-formatter/summary-string-onfail/TestSummaryStringOnFail.py @@ -8,9 +8,7 @@ import lldbsuite.test.lldbutil as lldbutil -class Radar9974002DataFormatterTestCase(TestBase): - # test for rdar://problem/9974002 () - +class SummaryStringOnFailDataFormatterTestCase(TestBase): def setUp(self): # Call super's setUp(). TestBase.setUp(self) diff --git a/lldb/test/API/lang/objc/rdar-10967107/Makefile b/lldb/test/API/lang/objc/coalesced-cf-types/Makefile similarity index 100% rename from lldb/test/API/lang/objc/rdar-10967107/Makefile rename to lldb/test/API/lang/objc/coalesced-cf-types/Makefile diff --git a/lldb/test/API/lang/objc/rdar-10967107/TestRdar10967107.py b/lldb/test/API/lang/objc/coalesced-cf-types/TestCoalescedCFTypes.py similarity index 97% rename from lldb/test/API/lang/objc/rdar-10967107/TestRdar10967107.py rename to lldb/test/API/lang/objc/coalesced-cf-types/TestCoalescedCFTypes.py index 3948940d4ddbd..56b80a3c55677 100644 --- a/lldb/test/API/lang/objc/rdar-10967107/TestRdar10967107.py +++ b/lldb/test/API/lang/objc/coalesced-cf-types/TestCoalescedCFTypes.py @@ -9,7 +9,7 @@ from lldbsuite.test import lldbutil -class Rdar10967107TestCase(TestBase): +class CoalescedCFTypesTestCase(TestBase): SHARED_BUILD_TESTCASE = False def setUp(self): diff --git a/lldb/test/API/lang/objc/rdar-10967107/main.m b/lldb/test/API/lang/objc/coalesced-cf-types/main.m similarity index 100% rename from lldb/test/API/lang/objc/rdar-10967107/main.m rename to lldb/test/API/lang/objc/coalesced-cf-types/main.m diff --git a/lldb/test/API/lang/objc/rdar-12408181/Makefile b/lldb/test/API/lang/objc/dynamic-type-children/Makefile similarity index 100% rename from lldb/test/API/lang/objc/rdar-12408181/Makefile rename to lldb/test/API/lang/objc/dynamic-type-children/Makefile diff --git a/lldb/test/API/lang/objc/rdar-12408181/TestRdar12408181.py b/lldb/test/API/lang/objc/dynamic-type-children/TestDynamicTypeChildren.py similarity index 98% rename from lldb/test/API/lang/objc/rdar-12408181/TestRdar12408181.py rename to lldb/test/API/lang/objc/dynamic-type-children/TestDynamicTypeChildren.py index 63e0555fb9b68..23ffeaeb86cb2 100644 --- a/lldb/test/API/lang/objc/rdar-12408181/TestRdar12408181.py +++ b/lldb/test/API/lang/objc/dynamic-type-children/TestDynamicTypeChildren.py @@ -14,7 +14,7 @@ # test if WindowServer isn't available. # Note: Simply applying the @skipIf decorator here confuses the test harness # and gives a spurious failure. -class Rdar12408181TestCase(TestBase): +class DynamicTypeChildrenTestCase(TestBase): SHARED_BUILD_TESTCASE = False def setUp(self): diff --git a/lldb/test/API/lang/objc/rdar-12408181/main.m b/lldb/test/API/lang/objc/dynamic-type-children/main.m similarity index 100% rename from lldb/test/API/lang/objc/rdar-12408181/main.m rename to lldb/test/API/lang/objc/dynamic-type-children/main.m _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
