labath added a comment.
Should I start looking at this or you have more changes planned? I still see
manual memory management in the Destroy function...
BTW, what's your testing strategy for this?
================
Comment at: source/Plugins/Process/Linux/ProcessorTrace.cpp:393
+ llvm::SmallVector<MutableArrayRef<uint8_t>, 2> parts = {
+ src.slice(src_cyc_index), src.drop_back(src.size() - src_cyc_index)};
+
----------------
Isn't the drop-back expression equivalent to `src.take_front(src_cyc_index)`?
https://reviews.llvm.org/D33674
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
