No objections here On Fri, Jun 23, 2017 at 5:48 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote:
> labath created this revision. > Herald added a subscriber: mgorny. > > The new UndefinedBehaviorSanitizer plugin was breaking file path length > limits, because it's (fairly long name) appears multiple times in the > path. Cmake ends up putting the object file at path > > tools/lldb/source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/CMakeFiles/lldbPluginInstrumentationRuntimeUndefinedBehaviorSanitizer.dir/UndefinedBehaviorSanitizerRuntime.cpp.obj > which is 191 characters long and very dangerously close to the 260 > character path limit on windows systems (also, just the include line for > that file was breaking the 80 character line limit). > > This renames the sanitizer plugins to use shorter names (asan, ubsan, > tsan). I think this will still be quite understandable to everyone as > those are the names everyone uses to refer to them anyway. > > > https://reviews.llvm.org/D34553 > > Files: > source/API/SystemInitializerFull.cpp > source/Plugins/InstrumentationRuntime/ASan/ASanRuntime.cpp > source/Plugins/InstrumentationRuntime/ASan/ASanRuntime.h > source/Plugins/InstrumentationRuntime/ASan/CMakeLists.txt > > source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.cpp > > source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.h > source/Plugins/InstrumentationRuntime/AddressSanitizer/CMakeLists.txt > source/Plugins/InstrumentationRuntime/CMakeLists.txt > source/Plugins/InstrumentationRuntime/TSan/CMakeLists.txt > source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.cpp > source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.h > source/Plugins/InstrumentationRuntime/ThreadSanitizer/CMakeLists.txt > > source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp > > source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.h > source/Plugins/InstrumentationRuntime/UBSan/CMakeLists.txt > source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp > source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.h > > source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/CMakeLists.txt > > source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/UndefinedBehaviorSanitizerRuntime.cpp > > source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/UndefinedBehaviorSanitizerRuntime.h > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
