labath added a comment.

thanks for the effort. I found the logic of the test quite difficult to follow, 
with multiple breakpoints and notify_calls(). Instead of trying to point out 
each problem, I figured it will be easier to write my take on how the test 
could look like: https://paste.ubuntu.com/24665770/.  Besides making the logic 
flow nicer (I hope), it also avoids a couple of other potentially problematic 
spots in your test (reliance on the exact way we number threads, potentially 
infinite loop in the thread.StepInstruction calls, etc).

Let me know what you think.


https://reviews.llvm.org/D33426



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to