labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Ok, I think this makes a reasonable starting point for further work. We just 
need to tighten the condition on when to run these tests.



================
Comment at: unittests/tools/CMakeLists.txt:1
+if(UNIX AND NOT APPLE)
+  add_subdirectory(lldb-server)
----------------
This is not what I meant. The only targets (at least until we have debugserver 
support) that can realistically pass these tests are linux, android, and 
netbsd. The other targets (right now, I guess that would mean freebsd) don't 
even pretend to support debugging via lldb-server, so we should not fail their 
build because of that. Check for usages of CMAKE_SYSTEM_NAME to see how to 
discriminate those.


https://reviews.llvm.org/D32930



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to