jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

This seems fine to me.

Zachary didn't give reasons why he didn't like the conversion form so I can't 
really assess that point.  The use in the ErrorConversion test case seems 
pretty natural to me, but it's possible I'm missing whatever was bugging him 
about this.  So I'll okay this for my part, but if you guys want to continue 
discussing, have at it!


https://reviews.llvm.org/D33241



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to