zturner added inline comments.
================
Comment at: source/Utility/ConstString.cpp:49
+ // pointer, we don't need the lock.
const StringPoolEntryType &entry = GetStringMapEntryFromKeyData(ccstr);
return entry.getKey().size();
----------------
Why do we even have this function which digs into the `StringMap` internals
rather than just calling existing `StringMap` member functions? Can Can we
just delete `GetStringMapEntryFromKeyData` entirely and use `StringMap::find`?
Repository:
rL LLVM
https://reviews.llvm.org/D32306
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
