Michael137 wrote: > I think this is just a side note, but it seemed like Greg's comment indicated > that the .o files for DWARFWithDebugMap are not expected to be in the global > module list. They definitely are: > > ``` > (lldb) image list -g > [ 0] C4CE9978-3413-365E-BA4D-8F6B0C3D4597 0x0000000100000000 /tmp/my_prog > ... > [ 41] 0x0000000000000000 > /private/tmp/my_prog.o > ``` > > and it is in fact really handy to have them there as it makes tracking down > the debug info from them easier.
I think Greg's original comment was about the lifetime of the `.o` modules. Something about making sure they're alive for long enough (i.e., `IntrusiveRefCntPtr` vs `shared_ptr`). IIUC one of the reasons we used to put them into the shared modules list was in order for them to not get deallocated. But sounds like that's guaranteed by some other mechanism now (but that doesn't imply they can't live in the shared module cache for other reasons). I'll go ahead and merge but let me know if you think there might still be a need for this https://github.com/llvm/llvm-project/pull/176325 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
