https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/176233
>From d6299733f808ffa1e10a80bba59b0c884a1f1487 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike <[email protected]> Date: Thu, 15 Jan 2026 19:53:33 +0000 Subject: [PATCH 1/2] [lldb-dap][NFC] Address comments grammar. --- lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp | 1 - lldb/tools/lldb-dap/Protocol/ProtocolRequests.h | 6 +++--- lldb/unittests/DAP/ProtocolTypesTest.cpp | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp index 23789f6d46f90..a72802a33fc9c 100644 --- a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp +++ b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.cpp @@ -335,7 +335,6 @@ bool fromJSON(const llvm::json::Value &Params, DAPSession &Ses, llvm::json::Path P) { json::ObjectMapper O(Params, P); - // Validate that both debuggerID and targetId are provided. return O && O.map("targetId", Ses.targetId) && O.map("debuggerId", Ses.debuggerId); } diff --git a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h index 9d5bdf1efe94c..77b575bc5d0e4 100644 --- a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h +++ b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h @@ -318,10 +318,10 @@ using LaunchResponse = VoidResponse; #define LLDB_DAP_INVALID_FRAME_ID UINT64_MAX struct DAPSession { - /// Unique ID of an existing target to attach to. + /// A Unique ID of an existing target to attach to. lldb::user_id_t targetId; - /// ID of an existing debugger instance to use. + /// A Unique ID of an existing debugger instance to use. lldb::user_id_t debuggerId; }; bool fromJSON(const llvm::json::Value &, DAPSession &, llvm::json::Path); @@ -360,7 +360,7 @@ struct AttachRequestArguments { /// Path to the core file to debug. std::string coreFile; - /// An Existing session that consist of a target and debugger. + /// An existing session that consist of a target and debugger. std::optional<DAPSession> session; /// @} diff --git a/lldb/unittests/DAP/ProtocolTypesTest.cpp b/lldb/unittests/DAP/ProtocolTypesTest.cpp index 6476492813455..82753d3fe0cfd 100644 --- a/lldb/unittests/DAP/ProtocolTypesTest.cpp +++ b/lldb/unittests/DAP/ProtocolTypesTest.cpp @@ -1264,7 +1264,7 @@ TEST(ProtocolTypesTest, StackFrame) { } TEST(ProtocolTypesTest, DAPSession) { - const DAPSession session{/*targetId*/ 1000, /*debuggerId*/ 300}; + const DAPSession session{/*targetId=*/1000, /*debuggerId=*/300}; auto expected = parse<DAPSession>(R"({"targetId": 1000, "debuggerId": 300})"); ASSERT_THAT_EXPECTED(expected, llvm::Succeeded()); >From 07d7e771562f387d0b2a0c76511519bf47e4f4b6 Mon Sep 17 00:00:00 2001 From: Ebuka Ezike <[email protected]> Date: Fri, 16 Jan 2026 16:17:47 +0000 Subject: [PATCH 2/2] [lldb-dap] add review changes --- lldb/tools/lldb-dap/Protocol/ProtocolRequests.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h index 77b575bc5d0e4..471484e1ba356 100644 --- a/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h +++ b/lldb/tools/lldb-dap/Protocol/ProtocolRequests.h @@ -318,10 +318,10 @@ using LaunchResponse = VoidResponse; #define LLDB_DAP_INVALID_FRAME_ID UINT64_MAX struct DAPSession { - /// A Unique ID of an existing target to attach to. + /// A unique ID of an existing target to attach to. lldb::user_id_t targetId; - /// A Unique ID of an existing debugger instance to use. + /// A unique ID of an existing debugger instance to use. lldb::user_id_t debuggerId; }; bool fromJSON(const llvm::json::Value &, DAPSession &, llvm::json::Path); _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
