https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/176257
Follow up fix to #175847 >From 5f35a7bbb4b574df9d52f25578eea59214717793 Mon Sep 17 00:00:00 2001 From: Dave Lee <[email protected]> Date: Thu, 15 Jan 2026 13:59:54 -0800 Subject: [PATCH] [lldb] Add missing newline to po warning Follow up fix to #175847 --- lldb/source/DataFormatters/ValueObjectPrinter.cpp | 2 +- .../objc/failing-description/TestObjCFailingDescription.py | 4 ++-- .../lang/objc/struct-description/TestObjCStructDescription.py | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lldb/source/DataFormatters/ValueObjectPrinter.cpp b/lldb/source/DataFormatters/ValueObjectPrinter.cpp index bdad8c0cc2343..f8b49075edd19 100644 --- a/lldb/source/DataFormatters/ValueObjectPrinter.cpp +++ b/lldb/source/DataFormatters/ValueObjectPrinter.cpp @@ -101,7 +101,7 @@ llvm::Error ValueObjectPrinter::PrintValueObject() { llvm::Expected<std::string> object_desc_or_err = GetMostSpecializedValue().GetObjectDescription(); if (!object_desc_or_err) { - *m_stream << "warning: `po` was unsuccessful, running `p` instead"; + *m_stream << "warning: `po` was unsuccessful, running `p` instead\n"; LLDB_LOG_ERROR(GetLog(LLDBLog::Expressions), object_desc_or_err.takeError(), "Object description fallback due to error: {0}"); diff --git a/lldb/test/API/lang/objc/failing-description/TestObjCFailingDescription.py b/lldb/test/API/lang/objc/failing-description/TestObjCFailingDescription.py index 134c40c6d070e..2c32901452fb9 100644 --- a/lldb/test/API/lang/objc/failing-description/TestObjCFailingDescription.py +++ b/lldb/test/API/lang/objc/failing-description/TestObjCFailingDescription.py @@ -14,7 +14,7 @@ def test(self): self.expect( "expr -O -- bad", - substrs=["`po` was unsuccessful, running `p` instead", "(Bad *) 0x"], + substrs=["`po` was unsuccessful, running `p` instead\n", "(Bad *) 0x"], ) self.filecheck( f"platform shell cat {log}", __file__, f"-check-prefix=CHECK-EXPR" @@ -23,7 +23,7 @@ def test(self): self.expect( "dwim-print -O -- bad", - substrs=["`po` was unsuccessful, running `p` instead", "_lookHere = NO"], + substrs=["`po` was unsuccessful, running `p` instead\n", "_lookHere = NO"], ) self.filecheck( f"platform shell cat {log}", __file__, f"-check-prefix=CHECK-DWIM-PRINT" diff --git a/lldb/test/API/lang/objc/struct-description/TestObjCStructDescription.py b/lldb/test/API/lang/objc/struct-description/TestObjCStructDescription.py index b03797fdef6e3..b6dc7637b45eb 100644 --- a/lldb/test/API/lang/objc/struct-description/TestObjCStructDescription.py +++ b/lldb/test/API/lang/objc/struct-description/TestObjCStructDescription.py @@ -15,7 +15,7 @@ def test(self): self.expect( "vo pair", substrs=[ - "warning: `po` was unsuccessful, running `p` instead", + "warning: `po` was unsuccessful, running `p` instead\n", "(Pair) pair = (f = 2, e = 3)", ], ) @@ -25,7 +25,7 @@ def test(self): self.expect( "expr -O -- pair", substrs=[ - "warning: `po` was unsuccessful, running `p` instead", + "warning: `po` was unsuccessful, running `p` instead\n", "(Pair) (f = 2, e = 3)", ], ) _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
