https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/176220
>From 9ea145fe65eb9858bab712c801fea9288fe0f386 Mon Sep 17 00:00:00 2001 From: Alex Langford <[email protected]> Date: Thu, 15 Jan 2026 10:40:52 -0800 Subject: [PATCH 1/2] [lldb][NFC] Make parameter const in SymbolFile::GetParameterStackSize --- lldb/include/lldb/Symbol/SymbolFile.h | 2 +- lldb/include/lldb/Symbol/SymbolFileOnDemand.h | 3 ++- lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp | 2 +- lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h | 3 ++- lldb/source/Symbol/SymbolFileOnDemand.cpp | 2 +- 5 files changed, 7 insertions(+), 5 deletions(-) diff --git a/lldb/include/lldb/Symbol/SymbolFile.h b/lldb/include/lldb/Symbol/SymbolFile.h index 9982852cc760d..ce3fe18771adb 100644 --- a/lldb/include/lldb/Symbol/SymbolFile.h +++ b/lldb/include/lldb/Symbol/SymbolFile.h @@ -397,7 +397,7 @@ class SymbolFile : public PluginInterface { /// Return the number of stack bytes taken up by the parameters to this /// function. - virtual llvm::Expected<lldb::addr_t> GetParameterStackSize(Symbol &symbol) { + virtual llvm::Expected<lldb::addr_t> GetParameterStackSize(const Symbol &symbol) { return llvm::createStringError(make_error_code(llvm::errc::not_supported), "Operation not supported."); } diff --git a/lldb/include/lldb/Symbol/SymbolFileOnDemand.h b/lldb/include/lldb/Symbol/SymbolFileOnDemand.h index b376de73419d4..6807ae2df8faa 100644 --- a/lldb/include/lldb/Symbol/SymbolFileOnDemand.h +++ b/lldb/include/lldb/Symbol/SymbolFileOnDemand.h @@ -175,7 +175,8 @@ class SymbolFileOnDemand : public lldb_private::SymbolFile { GetUnwindPlan(const Address &address, const RegisterInfoResolver &resolver) override; - llvm::Expected<lldb::addr_t> GetParameterStackSize(Symbol &symbol) override; + llvm::Expected<lldb::addr_t> + GetParameterStackSize(const Symbol &symbol) override; void PreloadSymbols() override; diff --git a/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp b/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp index 14932e957d081..39f21250649d8 100644 --- a/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp +++ b/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp @@ -498,7 +498,7 @@ void SymbolFileBreakpad::AddSymbols(Symtab &symtab) { } llvm::Expected<lldb::addr_t> -SymbolFileBreakpad::GetParameterStackSize(Symbol &symbol) { +SymbolFileBreakpad::GetParameterStackSize(const Symbol &symbol) { ParseUnwindData(); if (auto *entry = m_unwind_data->win.FindEntryThatContains( symbol.GetAddress().GetFileAddress())) { diff --git a/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h b/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h index 041b388f9f344..0bf67518efd5c 100644 --- a/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h +++ b/lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h @@ -132,7 +132,8 @@ class SymbolFileBreakpad : public SymbolFileCommon { void AddSymbols(Symtab &symtab) override; - llvm::Expected<lldb::addr_t> GetParameterStackSize(Symbol &symbol) override; + llvm::Expected<lldb::addr_t> + GetParameterStackSize(const Symbol &symbol) override; lldb::UnwindPlanSP GetUnwindPlan(const Address &address, diff --git a/lldb/source/Symbol/SymbolFileOnDemand.cpp b/lldb/source/Symbol/SymbolFileOnDemand.cpp index 9fc13c5989fc2..13ef8c70f7dc1 100644 --- a/lldb/source/Symbol/SymbolFileOnDemand.cpp +++ b/lldb/source/Symbol/SymbolFileOnDemand.cpp @@ -508,7 +508,7 @@ SymbolFileOnDemand::GetUnwindPlan(const Address &address, } llvm::Expected<lldb::addr_t> -SymbolFileOnDemand::GetParameterStackSize(Symbol &symbol) { +SymbolFileOnDemand::GetParameterStackSize(const Symbol &symbol) { if (!m_debug_info_enabled) { Log *log = GetLog(); LLDB_LOG(log, "[{0}] {1} is skipped", GetSymbolFileName(), __FUNCTION__); >From c6c81b8d0d92c03286ec7e76088f3026ea25d420 Mon Sep 17 00:00:00 2001 From: Alex Langford <[email protected]> Date: Thu, 15 Jan 2026 10:46:36 -0800 Subject: [PATCH 2/2] format --- lldb/include/lldb/Symbol/SymbolFile.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lldb/include/lldb/Symbol/SymbolFile.h b/lldb/include/lldb/Symbol/SymbolFile.h index ce3fe18771adb..6b53ba8b6acce 100644 --- a/lldb/include/lldb/Symbol/SymbolFile.h +++ b/lldb/include/lldb/Symbol/SymbolFile.h @@ -397,7 +397,8 @@ class SymbolFile : public PluginInterface { /// Return the number of stack bytes taken up by the parameters to this /// function. - virtual llvm::Expected<lldb::addr_t> GetParameterStackSize(const Symbol &symbol) { + virtual llvm::Expected<lldb::addr_t> + GetParameterStackSize(const Symbol &symbol) { return llvm::createStringError(make_error_code(llvm::errc::not_supported), "Operation not supported."); } _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
