[Lldb-commits] [lldb] [lldb] Step over non-lldb breakpoints (PR #174348)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. 
:warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp,c -- 
lldb/include/lldb/Core/Architecture.h lldb/include/lldb/Target/Platform.h 
lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.cpp 
lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.h 
lldb/source/Plugins/Architecture/Arm/ArchitectureArm.cpp 
lldb/source/Plugins/Architecture/Arm/ArchitectureArm.h 
lldb/source/Plugins/Architecture/Mips/ArchitectureMips.cpp 
lldb/source/Plugins/Architecture/Mips/ArchitectureMips.h 
lldb/source/Target/Platform.cpp lldb/source/Target/StopInfo.cpp 
lldb/test/API/functionalities/builtin-debugtrap/main.c --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/include/lldb/Core/Architecture.h 
b/lldb/include/lldb/Core/Architecture.h
index 38b307476..aaff8deb3 100644
--- a/lldb/include/lldb/Core/Architecture.h
+++ b/lldb/include/lldb/Core/Architecture.h
@@ -143,8 +143,9 @@ public:
   /// architecture. Some architectures have breakpoint instructions that
   /// have immediates that can take on any value, resulting in a family
   /// of valid byte sequences. Bases the size comparison on the reference.
-  virtual bool IsValidBreakpointInstruction(llvm::ArrayRef<uint8_t> reference,
-                                            llvm::ArrayRef<uint8_t> observed) 
const {
+  virtual bool
+  IsValidBreakpointInstruction(llvm::ArrayRef<uint8_t> reference,
+                               llvm::ArrayRef<uint8_t> observed) const {
     if (reference.size() > observed.size())
       return false;
     return !std::memcmp(reference.data(), observed.data(), reference.size());
diff --git a/lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.h 
b/lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.h
index c93150a01..502a55ba2 100644
--- a/lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.h
+++ b/lldb/source/Plugins/Architecture/AArch64/ArchitectureAArch64.h
@@ -39,8 +39,9 @@ public:
                                DataExtractor &reg_data,
                                RegisterContext &reg_context) const override;
 
-  bool IsValidBreakpointInstruction(llvm::ArrayRef<uint8_t> reference,
-                                    llvm::ArrayRef<uint8_t> observed) const 
override;
+  bool
+  IsValidBreakpointInstruction(llvm::ArrayRef<uint8_t> reference,
+                               llvm::ArrayRef<uint8_t> observed) const 
override;
 
 private:
   static std::unique_ptr<Architecture> Create(const ArchSpec &arch);
diff --git a/lldb/test/API/functionalities/builtin-debugtrap/main.c 
b/lldb/test/API/functionalities/builtin-debugtrap/main.c
index 84332d800..8010be4a0 100644
--- a/lldb/test/API/functionalities/builtin-debugtrap/main.c
+++ b/lldb/test/API/functionalities/builtin-debugtrap/main.c
@@ -1,7 +1,6 @@
 #include <stdio.h>
 int global = 0;
-int main()
-{
+int main() {
   global = 5; // Set a breakpoint here
   puts("");
   __builtin_debugtrap();

``````````

</details>


https://github.com/llvm/llvm-project/pull/174348
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits