Michael137 wrote: > > Should we keep a couple of tests that use the minus? Does DIL treat it as > > an arithmetic expression then? Probably not worth handling because we're > > getting close to expression evaluation territory? But I'd be curious what > > the error looks like, because i can imagine users trying to do it > > Since we don't have binary minus in the upstream yet, it will just complain > that the `-` token is unexpected. Once we do, it will subtract 2 values and > use the result as a single array subscript value, no error. It is just as > likely for users to actually expect this, subtracting 2 different variables > to get a specific index in some array.
Makes sense > > Probably not worth handling because we're getting close to expression > > evaluation territory? > > I don't think we should artificially limit the syntax specifically for square > brackets Yea supporting DIL expressions in subscript operators makes sense. > it's part of the goal to get as many expressions supported as possible. Yea as long as we admit that those are DIL expressions and we don't venture out of the "data inspection" domain, I agree https://github.com/llvm/llvm-project/pull/173410 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
