llvmbot wrote:

<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Ludovic Tyack (ludovictyack)

<details>
<summary>Changes</summary>

fix typo on GetBreakableLoadAddress call that cause lldb segmentation fault 
when setting breakpoints on arbitrary address

---
Full diff: https://github.com/llvm/llvm-project/pull/173034.diff


1 Files Affected:

- (modified) lldb/source/Plugins/Architecture/Mips/ArchitectureMips.cpp (+1-1) 


``````````diff
diff --git a/lldb/source/Plugins/Architecture/Mips/ArchitectureMips.cpp 
b/lldb/source/Plugins/Architecture/Mips/ArchitectureMips.cpp
index 3748be0533ad7..fe6eecb0daf28 100644
--- a/lldb/source/Plugins/Architecture/Mips/ArchitectureMips.cpp
+++ b/lldb/source/Plugins/Architecture/Mips/ArchitectureMips.cpp
@@ -113,7 +113,7 @@ lldb::addr_t 
ArchitectureMips::GetBreakableLoadAddress(lldb::addr_t addr,
   if (current_offset == 0)
     return addr;
 
-  auto insn = GetInstructionAtAddress(target, current_offset, addr);
+  auto insn = GetInstructionAtAddress(target, addr, current_offset);
 
   if (nullptr == insn || !insn->HasDelaySlot())
     return addr;

``````````

</details>


https://github.com/llvm/llvm-project/pull/173034
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to