weliveindetail wrote:

> Sorry about this. Should I revert the commit?

Well, the work is done and you have gained an understanding how the test works. 
That's a win too :) The new test is less maintainable for me, but if you take 
over maintenance, then this is fine. Also, this could be a good example of "how 
to write a test for Shell vs. API"?

> EDIT: Just saw https://github.com/llvm/llvm-project/pull/172292

For me personally, the JITLink pendant is the relevant one and I'd like to keep 
that as a LIT command-line test. You could consider to apply the same 
restriction to the API test, if you keep seeing flakes.

https://github.com/llvm/llvm-project/pull/170333
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to