Author: Adrian Vogelsgesang Date: 2025-12-08T13:14:41Z New Revision: 7c832fca5374cde2804cebc2ba3c5ad635fb76a1
URL: https://github.com/llvm/llvm-project/commit/7c832fca5374cde2804cebc2ba3c5ad635fb76a1 DIFF: https://github.com/llvm/llvm-project/commit/7c832fca5374cde2804cebc2ba3c5ad635fb76a1.diff LOG: [lldb] Fix command line of `target frame-provider register` (#167803) So far, the syntax was `target frame-provider register <cmd-options> [<run-args>]`. Note the optional `run-args` at the end. They are completely ignored by the actual command, but the command line parser still accepts them. This commit removes them. This was probably a copy-paste error from `CommandObjectProcessLaunch` which was probably used as a blue-print for `target frame-provider register`. Added: Modified: lldb/source/Commands/CommandObjectTarget.cpp Removed: ################################################################################ diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp index 6e8c94fa234cd..322dd6c502f27 100644 --- a/lldb/source/Commands/CommandObjectTarget.cpp +++ b/lldb/source/Commands/CommandObjectTarget.cpp @@ -5420,8 +5420,6 @@ class CommandObjectTargetFrameProviderRegister : public CommandObjectParsed { m_all_options.Append(&m_class_options, LLDB_OPT_SET_1 | LLDB_OPT_SET_2, LLDB_OPT_SET_ALL); m_all_options.Finalize(); - - AddSimpleArgumentList(eArgTypeRunArgs, eArgRepeatOptional); } ~CommandObjectTargetFrameProviderRegister() override = default; @@ -5434,7 +5432,7 @@ class CommandObjectTargetFrameProviderRegister : public CommandObjectParsed { } protected: - void DoExecute(Args &launch_args, CommandReturnObject &result) override { + void DoExecute(Args &command, CommandReturnObject &result) override { ScriptedMetadataSP metadata_sp = std::make_shared<ScriptedMetadata>( m_class_options.GetName(), m_class_options.GetStructuredData()); _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
