labath added inline comments.

================
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:675
+      llvm::Triple host_triple(llvm::sys::getDefaultTargetTriple());
+      target_arch.GetTriple().setOS(host_triple.getOS());
+    }
----------------
I'm not terribly happy with the default-to-host mode here, particularly as we 
already have some code which detects linux in 
ObjectFileELF::RefineModuleDetailsFromNote. I'm not terribly happy about that 
either, but I hope we could at least have just one dodgy detection code.

Did you check whether it's possible to extend that function to cover mips as 
well (probably the NT_FILE part, which searches for some `i386-linux-gnu` paths 
in the binary) ?


Repository:
  rL LLVM

https://reviews.llvm.org/D31280



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to