Author: jimingham Date: 2025-12-05T09:34:36-08:00 New Revision: 35c664d7ea25fd95e67b88c4a2d2f336690f1286
URL: https://github.com/llvm/llvm-project/commit/35c664d7ea25fd95e67b88c4a2d2f336690f1286 DIFF: https://github.com/llvm/llvm-project/commit/35c664d7ea25fd95e67b88c4a2d2f336690f1286.diff LOG: Move checking m_dummy_target to after raw-plus-option parsing. (#170888) CommandObjectBreakpointAddPattern is a raw command. I was adjusting the patch for changes to handle the dummy target changes done while the patch was in review, and I copied the lines to the beginning of the DoExecute, but in the case of raw commands, you have to do the option parsing by hand, and this was before the parsing was done so the state wasn't determined yet. Added: Modified: lldb/source/Commands/CommandObjectBreakpoint.cpp Removed: ################################################################################ diff --git a/lldb/source/Commands/CommandObjectBreakpoint.cpp b/lldb/source/Commands/CommandObjectBreakpoint.cpp index c06b3ee028b69..8e163fbfb8942 100644 --- a/lldb/source/Commands/CommandObjectBreakpoint.cpp +++ b/lldb/source/Commands/CommandObjectBreakpoint.cpp @@ -1255,8 +1255,6 @@ class CommandObjectBreakpointAddPattern : public CommandObjectRaw { CommandReturnObject &result) override { const bool internal = false; ExecutionContext exe_ctx = GetCommandInterpreter().GetExecutionContext(); - Target &target = - m_dummy_options.m_use_dummy ? GetDummyTarget() : GetTarget(); m_all_options.NotifyOptionParsingStarting(&exe_ctx); if (command.empty()) { @@ -1279,6 +1277,9 @@ class CommandObjectBreakpointAddPattern : public CommandObjectRaw { } printf("Pattern: '%s'\n", pattern.str().c_str()); + Target &target = + m_dummy_options.m_use_dummy ? GetDummyTarget() : GetTarget(); + BreakpointSP bp_sp; const size_t num_files = m_options.m_files.GetSize(); _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
