krytarowski added a comment. Fantastic!
I got a substantial portion of Process Plugin to work on NetBSD, to coordinate the work feel free to join IRC `#lldb` at OFTC -- e.g. do not waste time on FreeBSD Process Plugin. Demo: http://www.netbsd.org/~kamil/lldb/hello2.txt I'm working on on remaining few features in order to upstream them. ================ Comment at: source/Plugins/Platform/OpenBSD/PlatformOpenBSD.cpp:60 + +#if defined(__FreeBSD__) || defined(__OpenBSD__) + // Only accept "unknown" for the OS if the host is BSD and ---------------- Please delete `__FreeBSD__` here and from the FreeBSD platform switch for `__OpenBSD__`, but I don't insist on doing the FreeBSD tweak within the same commit. ================ Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:588 + } + } else if (strncmp(note.n_name.c_str(), "OpenBSD", 7) == 0) { + m_os = llvm::Triple::OpenBSD; ---------------- `note.n_name == "OpenBSD"` ? ================ Comment at: source/Plugins/Process/elf-core/ThreadElfCore.cpp:114 + + case llvm::Triple::OpenBSD: { + switch (arch.GetMachine()) { ---------------- I would consider to keep it sorted - after Linux. https://reviews.llvm.org/D31131 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
