Author: Kazu Hirata Date: 2025-11-21T20:31:54-08:00 New Revision: cc7e2067b1a0fd799a5bfeab4b11d399ea7831a2
URL: https://github.com/llvm/llvm-project/commit/cc7e2067b1a0fd799a5bfeab4b11d399ea7831a2 DIFF: https://github.com/llvm/llvm-project/commit/cc7e2067b1a0fd799a5bfeab4b11d399ea7831a2.diff LOG: [lldb] Remove redundant declarations (NFC) (#169003) In C++17, static constexpr members are implicitly inline, so they no longer require an out-of-line definition. Identified with readability-redundant-declaration. Added: Modified: lldb/source/Target/Target.cpp lldb/source/Utility/StringExtractorGDBRemote.cpp Removed: ################################################################################ diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp index 6fc8053038d10..5f2e7af54044a 100644 --- a/lldb/source/Target/Target.cpp +++ b/lldb/source/Target/Target.cpp @@ -156,8 +156,6 @@ static Status installExecutable(const Installer &installer) { return Status(); } -constexpr std::chrono::milliseconds EvaluateExpressionOptions::default_timeout; - Target::Arch::Arch(const ArchSpec &spec) : m_spec(spec), m_plugin_up(PluginManager::CreateArchitectureInstance(spec)) {} diff --git a/lldb/source/Utility/StringExtractorGDBRemote.cpp b/lldb/source/Utility/StringExtractorGDBRemote.cpp index 010149ad4b381..40b5d037d0463 100644 --- a/lldb/source/Utility/StringExtractorGDBRemote.cpp +++ b/lldb/source/Utility/StringExtractorGDBRemote.cpp @@ -12,9 +12,6 @@ #include <cstring> #include <optional> -constexpr lldb::pid_t StringExtractorGDBRemote::AllProcesses; -constexpr lldb::tid_t StringExtractorGDBRemote::AllThreads; - StringExtractorGDBRemote::ResponseType StringExtractorGDBRemote::GetResponseType() const { if (m_packet.empty()) _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
