https://github.com/JDevlieghere approved this pull request.
I'm on the fence about this one, and expressed my reluctance to Jason offline. My biggest grip is that it just feels wrong, particularly because it's a path that may or may not be meaningful to the host. Jason correctly points out that there is prior art there, such as the paths for all the loaded libraries, and that it's up to lldb to decide whether that path is meaningful. For the shared cache specifically, we can compare the UUID to make sure the file on disk matches the one debugserver is looking at. He also points out that there's no harm in having the information available from debugserver if we do end up needing it. So even though I don't like it, I don't have strong grounds for pushing back. https://github.com/llvm/llvm-project/pull/168474 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
