[Lldb-commits] [lldb] [lldb] Support arbitrary precision integer registers (PR #166363)

[David Spickett via lldb-commits]

Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <m4tej.ko...@gmail.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>,
Matej =?utf-8?q?Košík?= <matej.ko...@codasip.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/166...@github.com>


================
@@ -46,7 +46,8 @@ class RegisterValue {
     eTypeUInt16,
     eTypeUInt32,
     eTypeUInt64,
-    eTypeUInt128,
+    eTypeUIntN, /// < This value is used when the (integer) register is larger
+                /// than 64-bits.
----------------
DavidSpickett wrote:

I think the comment is incorrect because you've added test cases that use UintN 
for < 64-bit values. I may be mistaken about that.

I might be overlapping two things:
* The ability to construct something starting from an N bit value
* A RegisterValue of N bits

So it could be that for 7 bits say, yes you can start with a 7-bit number in a 
single byte, but what you end up with is a 64-bit value because that's the 
minimum storage size we can have.

(and this is not you misleading me, I just didn't think too hard about the 
distinction until now)

> [lldb] Support arbitrary precision integer registers

If so, the title should have " > 64-bit" appended to it. Or a note in the PR 
description that although you can start with N bits you'll always end up with N 
rounded up to a multiple of 64-bits due to how they're stored.

https://github.com/llvm/llvm-project/pull/166363
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits