n2h9 wrote:

Hey hey 

> > It looks like this patch was created with the help of AI. There's nothing 
> > inherently wrong with that, except that there's a bunch of places where it 
> > is diverging from the prevailing coding style. I highlighted some of those 
> > issues in the comments, but please do another pass of the PR yourself and 
> > make sure the new code matches the surrounding code.
> 
> Thanks for your review @JDevlieghere 🤗 !
> 
> Let me address the comments and I will double check to be sure the code is 
> matching prevailing coding style 😇 .

Hey hey @JDevlieghere hello.
I have addressed the comments :blush: could you please take a look once  you 
will have some time :hugs: .

Thank you :bowing_woman: 

https://github.com/llvm/llvm-project/pull/165163
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to