[Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

[Hugh Bellamy via Phabricator via lldb-commits]

hughbe created this revision.

I've been porting swift-lldb to Windows/MSVC, and encountered some 
size_t/unsigned implicit conversion warnings. I sent a PR 
(https://github.com/apple/swift-lldb/pull/161) and @jimingham suggested I push 
some of them here.


Repository:
  rL LLVM

https://reviews.llvm.org/D30926

Files:
  Core/FormatEntity.cpp


Index: Core/FormatEntity.cpp
===================================================================
--- Core/FormatEntity.cpp
+++ Core/FormatEntity.cpp
@@ -64,14 +64,14 @@
 #define ENTRY_CHILDREN(n, t, f, c)                                             
\
   {                                                                            
\
     n, nullptr, FormatEntity::Entry::Type::t,                                  
\
-        FormatEntity::Entry::FormatType::f, 0, llvm::array_lengthof(c), c,     
\
-        false                                                                  
\
+        FormatEntity::Entry::FormatType::f, 0,                                 
\
+        static_cast<uint32_t>(llvm::array_lengthof(c)), c, false               
\
   }
 #define ENTRY_CHILDREN_KEEP_SEP(n, t, f, c)                                    
\
   {                                                                            
\
     n, nullptr, FormatEntity::Entry::Type::t,                                  
\
-        FormatEntity::Entry::FormatType::f, 0, llvm::array_lengthof(c), c,     
\
-        true                                                                   
\
+        FormatEntity::Entry::FormatType::f, 0,                                 
\
+        static_cast<uint32_t>(llvm::array_lengthof(c)), c, true                
\
   }
 #define ENTRY_STRING(n, s)                                                     
\
   {                                                                            
\



Index: Core/FormatEntity.cpp
===================================================================
--- Core/FormatEntity.cpp
+++ Core/FormatEntity.cpp
@@ -64,14 +64,14 @@
 #define ENTRY_CHILDREN(n, t, f, c)                                             \
   {                                                                            \
     n, nullptr, FormatEntity::Entry::Type::t,                                  \
-        FormatEntity::Entry::FormatType::f, 0, llvm::array_lengthof(c), c,     \
-        false                                                                  \
+        FormatEntity::Entry::FormatType::f, 0,                                 \
+        static_cast<uint32_t>(llvm::array_lengthof(c)), c, false               \
   }
 #define ENTRY_CHILDREN_KEEP_SEP(n, t, f, c)                                    \
   {                                                                            \
     n, nullptr, FormatEntity::Entry::Type::t,                                  \
-        FormatEntity::Entry::FormatType::f, 0, llvm::array_lengthof(c), c,     \
-        true                                                                   \
+        FormatEntity::Entry::FormatType::f, 0,                                 \
+        static_cast<uint32_t>(llvm::array_lengthof(c)), c, true                \
   }
 #define ENTRY_STRING(n, s)                                                     \
   {                                                                            \

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits