https://github.com/Nerixyz commented:
The LLDB changes look good to me. Though, it looks like the LLVM tests are failing. It might be easier if you land the LLVM changes first. > Can you add a test that (used to) reproduce(s) the crash? Presumably this > isn't covered when running the API tests with PDB support? This feels similar to #166090 (i.e. an artifact of incremental linking), so testing is a bit more complex. yaml2pdb is probably the way to go here. Currently, that won't work, because the generated PDB is missing the section headers. I'll try to add this, so both PRs can have a test. https://github.com/llvm/llvm-project/pull/166455 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
