naveen-seth wrote: > > The goal of this change is to remove dependencies on the Driver. > > This part of PR description led me to believe that you're going to replace > some `clangDriver` dependencies with `clangOptions`, but I only saw you > adding `clangOptions` to various CMakeLists. I guess description can be > improved here (or my understanding, if I missed something). > > It seems that this PR is requiring downstream users who link with > `clangDriver` to also link with `clangOptions`. Because of this, I don't > consider this to be an NFC change, and would like to see a release note in > "Potentially breaking changes" section. > > I'd like @AaronBallman to sign this off before it's merged. He should be back > next week.
Thank you for reviewing! I’ve added the release note ([ae268d0](https://github.com/llvm/llvm-project/pull/163659/commits/ae268d0ead9d744cea016166cc04a21dae875c96)) and updated the PR title and description. https://github.com/llvm/llvm-project/pull/163659 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
