eugene added inline comments.
================
Comment at: include/lldb/Utility/Log.h:152
- Flags &GetOptions();
+ const Flags GetOptions() const;
----------------
Seems like const on return value is not really needed.
================
Comment at: include/lldb/Utility/Log.h:163
+ std::atomic<uint32_t> m_options{0};
+ std::atomic<uint32_t> m_mask{0};
+
----------------
Do we actually need atomics here?
It seems like the stream itself is protected by the mutex, and It doesn't seem
to affect performance.
Can we use the same (or a different) mutex to protect flags and options?
https://reviews.llvm.org/D30702
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
