[Lldb-commits] [PATCH] D29581: Initial implementation of SB APIs for Tracing support.

[Ravitheja Addepally via Phabricator via lldb-commits]

ravitheja added inline comments.


================
Comment at: include/lldb/API/SBTraceOptions.h:38
+  /// They should be formatted as a JSON Array.
+  void setTraceParams(lldb::SBStream &params);
+
----------------
clayborg wrote:
> This should probably be:
> 
> ```
> void setTraceParams(lldb::SBStructuredData &params);
> ```
> 
> Then we can add extra functions to SBStructuredData that allow you construct 
> one from XML, JSON, Apple plist, or any other structured data.
Hi, this would also mean we make SBTraceOptions a friend class of 
SBStructuredData so that we can get access to the StructuredDataObject inside ?


https://reviews.llvm.org/D29581



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits