sedymrak wrote:
I came to the same conclusion a little later than you.
The test I was experimented with:
```
--- a/lldb/unittests/Utility/RegisterValueTest.cpp
+++ b/lldb/unittests/Utility/RegisterValueTest.cpp
@@ -7,6 +7,8 @@
//===----------------------------------------------------------------------===//
#include "lldb/Utility/RegisterValue.h"
+#include "lldb/lldb-private-types.h"
+#include "lldb/Utility/DataExtractor.h"
#include "gtest/gtest.h"
#include <optional>
@@ -54,3 +56,21 @@ TEST(RegisterValueTest, GetScalarValue) {
Scalar((APInt(128, 0xffeeddccbbaa9988ull) << 64) |
APInt(128, 0x7766554433221100)));
}
+
+TEST(RegisterValueTest, SetValueFromData) {
+ uint8_t bytes[] = {0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77,
+ 0x88, 0x99, 0xaa, 0xbb, 0xcc, 0xdd, 0xee, 0xff};
+ lldb::offset_t length = sizeof(bytes);
+ lldb_private::DataExtractor data(bytes, length, lldb::eByteOrderLittle,
+ sizeof(nullptr));
+ lldb_private::RegisterInfo reg_info;
+ reg_info.byte_size = 16;
+ reg_info.byte_offset = 0;
+ reg_info.encoding = lldb::eEncodingUint;
+ RegisterValue rv128;
+ EXPECT_TRUE(rv128.SetValueFromData(reg_info, data, 0, false).Success());
+ Scalar s128;
+ EXPECT_TRUE(rv128.GetScalarValue(s128));
+ EXPECT_TRUE(s128 == Scalar((APInt(128, 0xffeeddccbbaa9988ull) << 64) |
+ APInt(128, 0x7766554433221100ull)));
+}
```
nicely failed on the `main` branch but it succeed in the the branch that
contains the fix.
I will think about it and push something today.
https://github.com/llvm/llvm-project/pull/163646
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
