JDevlieghere wrote: > The one question I had was regarding > > ``` > if (!LLDBServerUtilities::SetupLogging(log_file, log_channels, 0)) > return -1; > ``` > > and whether I should replace the -1 with `EXIT_FAILURE`
Personally I would keep the current value, as it seems to have been done on purpose, and the risk of breaking someone's workflow outweighs the benefit of slightly improving consistency. https://github.com/llvm/llvm-project/pull/162730 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
